Jan Segre

Results 100 comments of Jan Segre

We have since made at least one attempt at implementing this without too much success. But this improvement still applies.

I agree that it would be good to standardize this. Here are some popular examples: - django: https://github.com/django/django/blob/master/django/db/models/base.py - asyncio: https://github.com/python/cpython/blob/master/Lib/asyncio/tasks.py - twisted: https://github.com/twisted/twisted/blob/twisted-19.7.0/src/twisted/internet/interfaces.py I personally like django and asyncio...

This still applies and our docstrings are still not standardized.

This still applies. But will need a proper design to make sure we keep backwards compatibility.

1. is doable but 2. seems more complex, anyway this could still apply

This still applies and would be useful, although not too much of a priority since the downsides of not supporting IPv6 are minimal.

I'd say the whole module really should have 100% coverage, and it's not currently the case, [see the live coverage at the master branch](https://app.codecov.io/gh/hathornetwork/hathor-core/tree/master/hathor%2Ftransaction).