hathor-core icon indicating copy to clipboard operation
hathor-core copied to clipboard

Prevent propagation of voided vertices in `on_new_tx()`

Open glevco opened this issue 1 year ago • 2 comments

          @msbrogli commented on https://github.com/HathorNetwork/hathor-core-side-dag/pull/11#discussion_r1634980005:

Nice rule. I guess we can add it to the on_new_tx() propagation part.

Originally posted by @glevco in https://github.com/HathorNetwork/hathor-core/pull/1061#discussion_r1635170175

glevco avatar Jun 13 '24 18:06 glevco

Is this specific to sync-v2? Either way we'd need a careful examination before doing this.

jansegre avatar Oct 17 '24 17:10 jansegre

I don't think this is too relevant for now, specially since I'm refactoring multiple parts of the P2P and specifically this PR changes this. Maybe we can leave it on hold and review it again in the future.

glevco avatar Oct 17 '24 18:10 glevco