Jan Segre

Results 100 comments of Jan Segre

The stratum server is being deprecated. This issue could be split in: remove stratum server, and move merged mining server to a separate project.

Some comments appeared because I initially targeted `master` instead of `dev`.

I'm not familiar with docker-compose, would it be possible to make the `peer.json` generation easier? Like a start script that checks for `/data/peer.json` and generates one if not present. Otherwise...

We only have to settle where to add this then.

What about a `composer-templates` or `deploy-templates` or `composer-examples` repo for storing this, along with examples of a composer with a headless wallet and whatnot.

Another suggestion was to also move the "check ready transactions" from `DepsIndex.next_ready_for_validation` to somewhere like `RocksDBDepsIndex.remove_from_ready_for_validation` (and renaming it accordingly).

The proposed feature works but introduces a regression when trying to quit via SIGINT (CTRL+C). Marked as draft until this regression is fixed.

What is the expected behavior? I think it should return a proper 409 error code, that is not what happens, right?

Currently we don't support to rocksdb on Windows. Be it Windows 10, 11 (7, XP, ...). Mainly because of two reasons: - there aren't official builds of the rocksdb lib...

I think @pedroferreira1 made good progress on this. Probably not as convenient as a `@with_settings(FooSettings)`, but we're already using different settings to test the genesis of testnet and mainnet.