Jan Nedbal comments

Results 179 comments of


                                            Jan Nedbal

@secured annotation does not work with actions

Are you going to implement this feature?

Calling initDefaults breaks data retrieving in develop branch

Commit e4abdef49f2c12e84e3eff3a06a574fd6150f3b5 caused this, any chance this will be reverted? Should I send PR?

Calling initDefaults breaks data retrieving in develop branch

@Tharos Develop branch is now merged in stable, did you miss this issue?

Calling initDefaults breaks data retrieving in develop branch

@castamir So this behaviour has changed in 3.0 and will not be reverted in future releases of 3.x (but there should be big warning about this BC break in release...

Query result type inference too generic for certain function results

Thank you, now I see the huge complexity you were dealing when implementing this. Good work! Anyway, shouldnt you be able to detect all those settings from EM when provided...

Query result type inference too generic for certain function results

> Maybe we could add a config parameter for this. I think that would be beneficial.

Query result type inference too generic for certain function results

> it makes the resulting code more portable That might be super important for libraries, but not for company codebase, where you use single driver and single setup. So as...

Unresolvable type error in PHPUnit\assertSame when the same enum is passed for second time

@ondrejmirtes Any reference to a fix?

Unresolvable type error in PHPUnit\assertSame when the same enum is passed for second time

That fixes the issue, but it is pretty unclear from the error message. Hopefully people find this thread then...

Failing test for broken implicitThrows (Throwable returned)

I was hoping you tell me just remove that nonsense condition here :) I can create also an issue if you want, so should I?