Jan Nedbal

icon indicating a website link https://janedbal.cz

icon company @shipmonk-rnd icon location Prague icon location I ❤️ open-source, static analysis and CI. Last year I made 1200+ contributions to @phpstan, @doctrine, @symfony, @composer and others.

Results 183 comments of Jan Nedbal

[suggestion] No shadow variable

[Right](https://phpstan.org/r/4317ff4c-ac0e-4f94-805b-fb53263eb69d), so closing. Thx

Failing test for setFetchMode(EAGER) that breaks the loaded collection when custom PK type is used

If you have a fix proposal, I can even fix the issue. So far, I believe we need to extract identifiers from [those entities](https://github.com/doctrine/orm/blob/5a541b8b3a327ab1ea5f93b1615b4ff67a34e109/src/UnitOfWork.php#L2670) and use its `DbalType::convertToDatabaseValue` to fix...

Failing test for setFetchMode(EAGER) that breaks the loaded collection when custom PK type is used

Still valid issue.