Jan Nedbal comments

Results 179 comments of


                                            Jan Nedbal

QueryResultTypeWalker: resolve if int/float/bool is fetched as native type or stringified

@VincentLanglet I've some stuff in backlog to do first before returning to this. But the outline what needs to be done: - (1) Decide how to deal with [untested drivers](https://github.com/janedbal/php-database-drivers-fetch-test)....

class_exists(Interface::class) is always false

> I'd rather be if this was somehow done in ClassExistsFunctionTypeSpecifyingExtension I agree, but cannot we do it as next step and merge this? ---- *Note: I dont feel implementing...

class_exists(Interface::class) is always false

> We're in no rush here and doing this correctly can always teach us something new :) Ok, then we can probably close this PR.

Report useless type in union (phpdoc, param/return, catch)

For reference, here is my last report toward the same issue: https://github.com/phpstan/phpstan/issues/5776

Report useless type in union (phpdoc, param/return, catch)

We implemented such rule here: https://github.com/shipmonk-rnd/phpstan-rules?tab=readme-ov-file#forbidnotnormalizedtype But it does not yet check catch statements. I think it shouldnt be hard to add it.

Report useless type in union (phpdoc, param/return, catch)

> Do you think it could be appropriate to contribute this on the phpstan strict-rule repository ? Personally, I see most of our rules as "extra strict" and "opinionated" similary...

DynamicFunctionReturnTypeExtension / DynamicFunctionThrowTypeExtension not executed for anonymous functions

I'd like to test it, will that be part of 1.10.x?

DynamicFunctionReturnTypeExtension / DynamicFunctionThrowTypeExtension not executed for anonymous functions

I'd say the underlying problem is now solved, so maybe close this?

Always false error does not mention subtracted type causing misleading error messages

Looks similar to https://github.com/phpstan/phpstan/issues/10386

EnforceReadonlyPublicPropertyRule false positive with property override

I think you should change the default value in constructor of the child. But I think we can change the rule not to report when public prop is overridden. It...