Jan Nedbal

Results 179 comments of Jan Nedbal

Bugreport: https://github.com/phpstan/phpstan/issues/9826

The matrix (at some level) should also contain: - driver (there are more for mysql and pgsql and some of them [behave differently](https://github.com/janedbal/php-database-drivers-fetch-test/blob/7a53490/tests/PhpDatabaseDriverTest.php#L77)) - config (mainly stringification on/off for PDO...

Looks very similar to https://github.com/phpstan/phpstan/issues/7538

> Is there more places in Symfony that would benefit from this annotation ? Probably yes, basically any method that accepts `callable` and does `$callback()` inside. Another example might be...

> I've found some other by searching for $callback(: Obviously, the parameter can be named differently. Best way to detect those is some simple custom PHPStan rule imo.

> Please check fabbot.io build, it is failing [The diff suggested by fabbot](https://fabbot.io/patch/symfony/symfony/54654/ac71bf526ae9390def7b3062a290f132e688504a/cs.diff) imo worsens the readability, do you really want that applied?

[Readme](https://github.com/phpstan/phpstan-doctrine?tab=readme-ov-file#query-type-inference) states that `NEW` should work. Are you suggesting it does not? > Most DQL features are supported, including GROUP BY, DISTINCT, all flavors of JOIN, arithmetic expressions, functions, aggregations,...

Note: ~~this is still WIP and I still plan to finalize this, but~~ implementing all the built-in SQL functions is non-trivial when considering all edge-cases. To be able to implement...

The green CI here is misleading, there is still ton of work awaiting (`walkFunction` is wrong, `DoctrineTypeDescriptor::getDatabaseInternalType` has no access to driver so it cannot return proper type, tests need...

@VincentLanglet Pushed the WIP so that you can check the direction I'm leaning towards.