Jan Nedbal

Results 179 comments of Jan Nedbal

The thing is that we fixed discovery of [this class usage](https://github.com/rectorphp/rector-src/blob/d62611eefb126db6c1037bbb50fbd2b2f8df1731/build/config/config-downgrade.php#L10) (previously was unseen). And since the file `build/config/config-downgrade.php` is [not discoverable by composer autoloader](https://github.com/rectorphp/rector-src/blob/d62611eefb126db6c1037bbb50fbd2b2f8df1731/composer.json#L67-L103), it gets reported as unknown....

We **somehow** managed to use custom rules, but it is more-less just a prompt-injection hack: ```sh docker run \ -e DYNACONF_OPENAI__KEY=$_YOUR_OPENAI_KEY \ -e DYNACONF_CONFIG__GIT_PROVIDER="gitlab" \ -e DYNACONF_GITLAB__URL="https://gitlab.com" \ -e DYNACONF_GITLAB__PERSONAL_ACCESS_TOKEN=$_YOUR_GL_TOKEN...

Yeah, extensions are a bit more tricky due to that optional dependency in libraries ([example](https://github.com/nette/utils/blob/736c567e257dbe0fcf6ce81b4d6dbe05c6899f96/src/Utils/Strings.php#L119)). Adjusting reported issues for suggested extensions might improve the DX there for sure. I'll consider...

Can we fix `@throws` in next step? I believe this already improves things.

This would be really handy! I was about to migrate to your tool from https://github.com/editorconfig-checker/editorconfig-checker.php (mainly because it lacks autofix feature), but I have some config file with ignores that...

Or some simple bash to extract lines from "ignore config": ```json "scripts": { "check:ec": "ec --exclude=$(paste -sd, .editorconfig-ignore)" } ```

> We should get inspired about that here. Can you be more specific please? Which part of current implementation is wrong and need to be adjusted?

> I could try to implement this addition to the rule and provide the PR if there will be any support. Sure, please send PR.