Jan Nedbal comments

Results 179 comments of


                                            Jan Nedbal

Ignore errors while loading ObjectManager

IIRC, some things happen too early making this impossible. But not sure this is also the case.

Analyse usages in composer scripts

I think you can easily use the same approach as [described in readme](https://github.com/shipmonk-rnd/composer-dependency-analyser?tab=readme-ov-file#detecting-classes-from-non-php-files) for this.

Return of mixed in `$this->createQueryBuilder()->getQuery()->getResult()` when alias is `ev` or `event`

Replicated: https://github.com/phpstan/phpstan-doctrine/pull/609

Return of mixed in `$this->createQueryBuilder()->getQuery()->getResult()` when alias is `ev` or `event`

Yes, because reflector see Event class as existing due to this stub: - phar:///app/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/SourceLocator/SourceStubber/../../../../../jetbrains/phpstorm-stubs/event/event.stub ![image](https://github.com/user-attachments/assets/b4d72bb9-97b6-4eb9-845d-ee5a3e14faf1)

Return of mixed in `$this->createQueryBuilder()->getQuery()->getResult()` when alias is `ev` or `event`

@ondrejmirtes added this condition [here](https://github.com/phpstan/phpstan-doctrine/commit/0edf5b0cf1ff0a85adeefe4b5c1a6ba238f961cc). I think we should be more careful where we do this check. Imo only in `->from(class-name)` etc. Not in such a generic way for every...

Return of mixed in `$this->createQueryBuilder()->getQuery()->getResult()` when alias is `ev` or `event`

I believe it would be the same issue as https://github.com/phpstan/phpstan-doctrine/issues/566

`Squiz.Arrays.ArrayDeclaration.NoComma` adds invalid comma to certain `match` statements since `3.10.1`

We were actually using more from that, this was just the most simple example to show the bug. But since it is buggy and wont be maintained, we will disable...

PHPStan crashes on ConstantArrayType::getAllArrays()

> I need to think about it a bit. Any outcome how to properly fix this? Thx

Option to disable phpstan-ignore-line and phpstan-ignore-next-line

You can easily deny the old approach by some super-simple CI script. We did the same thing here: https://github.com/shipmonk-rnd/phpstan-rules/pull/246

Detect invalid phpunit `@dataProvider`

Also, since PHPUnit 11, it checks if data provider "named arguments" match the param names. And if not, PHPUnit fails hard. So that might also be part of the "invalid...