Jan Nedbal

Results 179 comments of Jan Nedbal

@dg Any chance you find a minute to look at this? Thank you

> Wouldn't it be easier to solve it in StringNode using property $indentation as in BlockArrayNode? Tried in #78, but `StringNode` is also created in `Parser::parseValue` where I was not...

@dg Can you give a second look? Thank you.

@Kingdutch Here is OS lib for exactly what you ask for: [shipmonk/phpstan-baseline-per-identifier](https://github.com/shipmonk-rnd/phpstan-baseline-per-identifier).

It looks like you are looking for **detection of "unused trait use"**. Currently, there is no such thing, we only detect dead methods, constants and enum cases so far. Thus,...

@ruudk Thx, I can imagine such problems, but you can always disable the analysis: ```neon ignoreErrors: - identifier: shipmonk.deadEnumCase ``` And some codebases may benefit from this. Also, those mapped...

> I just had an idea, whenever from or tryFrom is called on an enum, we should mark the enum as not dead. > Together with the fact that it's...

How did you register such resolver? I thought you need to have it in DIC (which is detected): ```yaml services: ShipMonk\InputMapper\InputArgumentValueResolver: tags: - name: controller.argument_value_resolver ```

To induce that constructor is used once `#[Autowire]` is used, we probably [also need something like this](https://github.com/shipmonk-rnd/dead-code-detector/issues/91#issuecomment-2351020649).