dead-code-detector icon indicating copy to clipboard operation
dead-code-detector copied to clipboard

Unused traits are not beign reported

Open klapuch opened this issue 10 months ago • 1 comments

Hello,

Thank you for providing a great set of rules! We've encountered an unexpected behavior, and I'd like to discuss whether this is intentional or if there's something we can do about it.

The issue relates to traits. When we use a trait from a third-party package (a "vendor" package) without actually using any of its methods, no error is raised—regardless of method visibility. However, when we use our own traits within the project, unused methods are correctly reported. I would expect the same behavior for vendor traits as our project traits.

To illustrate this, I've prepared a minimal demo: https://github.com/klapuch/DeadCodeTest

Thank you!

klapuch avatar Mar 07 '25 12:03 klapuch

It looks like you are looking for detection of "unused trait use". Currently, there is no such thing, we only detect dead methods, constants and enum cases so far. Thus, we do not report unused things in vendor as you cannot really remove the method from there.

But thanks for the idea, we can consider implementing this in future.

janedbal avatar Mar 07 '25 12:03 janedbal