James Hilliard

Results 285 comments of James Hilliard

> But `RS485.write` method adds additional, blocking delays (for example, it always flushes the port after each write), which should not be executed in the async writer's callbacks, because it's...

> First of all it seems you forgot to cover the sync client. Yeah, the sync client code is rather...tricky IMO, trying to get it working there. > The purpose...

> having a short read, is normal (I am sitting with a device right now that does it) I mean, I made it a flag tied to the specific request...

> Will protoc v3 assumptions work if actual `protoc` version is much higher? (I've never used protoc myself) I think so, the versioning scheme changed to use much higher numbers...

@mihaimaruseac why was this closed? Reopened as #96999.

> too old with no reviews, hopefully the new one works Kinda confusing why this wasn't merged a while back, I mean #60021 was merged and it was basically identical...

@fantix Think you could spin a new release with python 3.13 support?