James Hilliard

> However such a change really needs a number of specific test cases (the major problem seems to be if a custom class is added and then used with a...

> Either it should work with all framers, or the library should warn the user so we can avoid issues. Yeah, so it's a bit unclear to me how this...

Going to close this for now, still may make sense eventually to add this but the sync transaction code is too messy at the moment for me to implement this,...

Is pymodbus supposed to throw an exception during the read if it's incomplete, I've been seeing this pattern a lot in our error reporting when using `AsyncModbusSerialClient` on pymodbus version...

> You should test data, that do not always have registers as return value, but an error instead. Well...sometimes there's actually register data there in the `data.registers` variable, but not...

> We do not check the amount you requested against the amount received that is for the app to do. That's rather...unexpected behavior, what use case would there be for...

> Normally the error flag will be set in this condition, which you do not check. Does this error flag only get set after all retries have been attempted for...

> The error flag get set when there are an error condition. So it gets set if there is an initial error on the first request but a subsequent retry...

> ModbusException is, as documented, raised for internal errors, the error flag is for device errors. Of course that can be changed, but it would affect all apps using pymodbus,...

> but one do not have all configured so it only returns what is has. So when you have a partial read like this how do you know which specific...