James Hilliard
James Hilliard
> Ps. pleasing mypy is NOT a reason! nor is having strongly typing in tests. Came up with another approach that works on both mypy and pylint that gets rid...
@ofek Think you could take a look at this?
FYI tests on master are currently [broken](https://github.com/jameshilliard/hatch/actions/runs/10951900955) same as here so I don't think this is introducing any regressions.
> Wouldn't it be enough to simply stop scanning upwards the file tree when we encounter a `pyproject.toml` or a `hatch.toml`? Technically that would also prevent the issue I was...
> In my case, the situation was a bit special, since the python project I was working on was completely unrelated to any VCS. It was just a random project...
> It looks like your fix indeed does not work for my case. Did I miss something? Hmm, try with `print(patterns)` above [this line](https://github.com/pypa/hatch/blob/10d23087d03c7ba51a5564402701d01de0f6f6f6/backend/src/hatchling/builders/config.py#L887) and see what it's showing.
> $ pip freeze | grep hatch > hatch @ git+https://github.com/jameshilliard/hatch.git@10d23087d03c7ba51a5564402701d01de0f6f6f6 > hatchling==1.25.0 I think this is your issue, you forgot to actually install my change from this PR, the...
> Do you have an example so that I could reproduce? Just build any package using hatchling from an extracted sdist inside a gitignored directory, for example: If our top...
rebased again