James Hilliard
James Hilliard
> there are a couple of CI problems Hmm, fixed everything except a test coverage percentage check, not sure what to do about that one.
Tests passing now.
> May I politely suggest, you do typing in this PR and not a lot of code changes ! All code changes made are directly due to issues being flagged...
> Please stop extending this PR, you still have not solved the basic problems in transaction.py Yeah, I should probably split off those test fixes, it ended up being more...
> However I can just as well tell you, your test changes are unwanted because the only complicate tests and does nothing to improve the production code. I'm confused, the...
> We do not run mypy and a number of the other tools an test, specifically because there are a larger number of lines flagged, which actually are ok or...
> Well if there are actual logic errors, then the code do not work as we want, and thus it is a bug.....problem is that mypy is very do not...
> It is a non typed language, because you can start using variables without giving them a type, and a variable freely be assigned all kind of types. So...dynamically typed...
> No dynamically typed (e,g, java) is different, as the name indicates a type is added dynamically, and the interpreter uses that to e.g. assign storage. Java is actually statically...
> Most people do not care about how the compiler works as long as it does the job, which is a pity because it often leads to programs with a...