kafka_exporter icon indicating copy to clipboard operation
kafka_exporter copied to clipboard

Missing health check statement in dockerfile

Open shatovilya opened this issue 10 months ago • 1 comments

To add a healthcheck to a Dockerfile, you can use the HEALTHCHECK statement. This instruction allows you to define a command that will check the state of the container. In your case, you can add a healthcheck that will check if the Kafka exporter metrics are available on port 9308.

shatovilya avatar Feb 05 '25 10:02 shatovilya

The current version check for 3.0.0+ fails to handle cases where protoc is above version 3.0.0 but does not start with a 3, for example protoc may have a version of 28.1.

To fix this use AX_COMPARE_VERSION to properly compare the version.

Will protoc v3 assumptions work if actual protoc version is much higher? (I've never used protoc myself)

@mrunge any comments?

eero-t avatar Mar 12 '25 14:03 eero-t

Will protoc v3 assumptions work if actual protoc version is much higher? (I've never used protoc myself)

I think so, the versioning scheme changed to use much higher numbers or something but it seems compatible with the normal assumptions regarding the version being greater than 3.

jameshilliard avatar Mar 13 '25 00:03 jameshilliard