node test_runner: handle file rename and deletion under watch mode

test_runner: handle file rename and deletion under watch mode

Open jakecastelli opened this issue 1 year ago • 1 comments

trafficstars

Fixes: #53113

Open the PR to first verify the idea and picking up how to do things properly. If the fix is on the right track, I will add tests cases shortly.

May 23 '24 07:05 jakecastelli

Review requested:

May 23 '24 07:05 nodejs-github-bot

@MoLow I have added tests to cover both rename and delete a watched test file 👍 could you please take a look when you have time

May 25 '24 15:05 jakecastelli

Could someone help me to kick start the CI? 👀

Thanks!

May 31 '24 04:05 jakecastelli

CI: https://ci.nodejs.org/job/node-test-pull-request/59582/

May 31 '24 21:05 nodejs-github-bot

Looks like there are a few failing jobs (most likely flaky tests 👀) I guess they need a rerun?

Jun 01 '24 06:06 jakecastelli

CI: https://ci.nodejs.org/job/node-test-pull-request/59600/

Jun 01 '24 13:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/59615/

Jun 02 '24 06:06 nodejs-github-bot

Landed in 7125931f4c891d253170146a97fc068f09cd2480

Jun 02 '24 08:06 nodejs-github-bot