TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Drop unnecessary type arguments in the isolated declarations quick fix

Open blickly opened this issue 1 year ago • 2 comments

Drops unnecessary type arguments in the isolated declarations quick fix by repeatedly trying to resolve a resulting reference type with a prefix of the full type arguments until finding the minimal number of arguments that work.

Fixes #58449

(I'm sure that the code at present isn't using the proper APIs, but I'd appreciate feedback)

blickly avatar Aug 17 '24 03:08 blickly

OK, I switched to the more idiomatic way of creating a new AST node, rather than trying to mutate anything. PTAL

blickly avatar Aug 20 '24 16:08 blickly

Any advice on who would make a good secondary reviewer?

blickly avatar Aug 28 '24 20:08 blickly

Tested locally with main and it merges and passes cleanly.

jakebailey avatar Sep 16 '24 17:09 jakebailey