TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Fixed nullish coalesce operator's precedence

Open Andarist opened this issue 9 months ago • 6 comments

fixes https://github.com/microsoft/TypeScript/issues/61369

Andarist avatar Mar 07 '25 14:03 Andarist

@typescript-bot test it

jakebailey avatar Mar 07 '25 19:03 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

typescript-bot avatar Mar 07 '25 19:03 typescript-bot

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61372/merge:

Everything looks good!

typescript-bot avatar Mar 07 '25 20:03 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot avatar Mar 07 '25 20:03 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 194,186k (± 0.96%) 194,163k (± 0.94%) ~ 192,898k 196,561k p=1.000 n=6
Parse Time 1.31s (± 0.62%) 1.31s (± 0.75%) ~ 1.29s 1.32s p=0.673 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.74s (± 0.37%) 9.74s (± 0.42%) ~ 9.70s 9.80s p=0.872 n=6
Emit Time 2.72s (± 0.83%) 2.73s (± 0.50%) ~ 2.72s 2.75s p=0.256 n=6
Total Time 14.50s (± 0.19%) 14.51s (± 0.29%) ~ 14.45s 14.56s p=0.687 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,670 948,670 ~ ~ ~ p=1.000 n=6
Types 410,947 410,947 ~ ~ ~ p=1.000 n=6
Memory used 1,224,306k (± 0.00%) 1,224,293k (± 0.00%) ~ 1,224,275k 1,224,314k p=0.689 n=6
Parse Time 6.62s (± 0.90%) 6.62s (± 0.93%) ~ 6.56s 6.70s p=0.560 n=6
Bind Time 1.89s (± 0.87%) 1.89s (± 0.97%) ~ 1.86s 1.90s p=0.933 n=6
Check Time 31.93s (± 0.52%) 31.92s (± 0.35%) ~ 31.81s 32.11s p=0.810 n=6
Emit Time 15.29s (± 0.70%) 15.27s (± 0.30%) ~ 15.21s 15.33s p=0.687 n=6
Total Time 55.73s (± 0.26%) 55.70s (± 0.28%) ~ 55.54s 55.97s p=0.810 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,347,571 2,347,571 ~ ~ ~ p=1.000 n=6
Types 845,646 845,646 ~ ~ ~ p=1.000 n=6
Memory used 2,121,799k (± 0.00%) 2,121,890k (± 0.01%) ~ 2,121,750k 2,122,020k p=0.298 n=6
Parse Time 7.32s (± 0.28%) 7.37s (± 2.04%) ~ 7.26s 7.66s p=0.936 n=6
Bind Time 2.44s (± 0.60%) 2.38s (± 6.80%) ~ 2.06s 2.49s p=1.000 n=6
Check Time 72.56s (± 0.66%) 72.22s (± 0.94%) ~ 70.98s 72.89s p=0.471 n=6
Emit Time 0.15s (± 5.07%) 0.15s (± 5.76%) ~ 0.14s 0.16s p=0.432 n=6
Total Time 82.46s (± 0.57%) 82.11s (± 0.81%) ~ 80.90s 82.77s p=0.378 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,697 1,226,713 +16 (+ 0.00%) ~ ~ p=0.001 n=6
Types 266,990 267,012 +22 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 2,357,043k (± 0.03%) 2,357,381k (± 0.02%) ~ 2,356,762k 2,357,960k p=0.230 n=6
Parse Time 5.19s (± 0.62%) 5.21s (± 0.34%) ~ 5.18s 5.23s p=0.518 n=6
Bind Time 1.77s (± 0.77%) 1.77s (± 1.26%) ~ 1.74s 1.80s p=0.685 n=6
Check Time 35.28s (± 0.26%) 35.26s (± 0.20%) ~ 35.18s 35.38s p=0.936 n=6
Emit Time 3.00s (± 1.17%) 3.00s (± 1.29%) ~ 2.96s 3.05s p=0.936 n=6
Total Time 45.25s (± 0.26%) 45.26s (± 0.20%) ~ 45.14s 45.41s p=0.810 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,697 1,226,713 +16 (+ 0.00%) ~ ~ p=0.001 n=6
Types 266,990 267,012 +22 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,032,604k (± 9.77%) 2,910,629k (±12.86%) ~ 2,426,214k 3,154,478k p=0.230 n=6
Parse Time 6.98s (± 0.98%) 6.93s (± 1.56%) ~ 6.78s 7.09s p=0.378 n=6
Bind Time 2.13s (± 0.96%) 2.15s (± 1.71%) ~ 2.10s 2.19s p=0.375 n=6
Check Time 42.91s (± 0.45%) 42.88s (± 0.60%) ~ 42.50s 43.21s p=0.936 n=6
Emit Time 3.51s (± 1.04%) 3.59s (± 2.62%) ~ 3.51s 3.76s p=0.093 n=6
Total Time 55.54s (± 0.42%) 55.54s (± 0.67%) ~ 54.97s 55.93s p=0.689 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,669 262,668 -1 (- 0.00%) ~ ~ p=0.001 n=6
Types 106,848 106,848 ~ ~ ~ p=1.000 n=6
Memory used 440,432k (± 0.02%) 440,437k (± 0.02%) ~ 440,281k 440,528k p=0.936 n=6
Parse Time 3.54s (± 0.97%) 3.52s (± 0.30%) ~ 3.51s 3.54s p=0.684 n=6
Bind Time 1.31s (± 0.62%) 1.31s (± 0.89%) ~ 1.29s 1.32s p=0.498 n=6
Check Time 18.87s (± 0.32%) 18.90s (± 0.39%) ~ 18.79s 19.01s p=0.518 n=6
Emit Time 1.52s (± 1.28%) 1.52s (± 1.10%) ~ 1.49s 1.54s p=0.669 n=6
Total Time 25.24s (± 0.31%) 25.25s (± 0.34%) ~ 25.11s 25.37s p=0.687 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,981 225,981 ~ ~ ~ p=1.000 n=6
Types 94,356 94,356 ~ ~ ~ p=1.000 n=6
Memory used 371,198k (± 0.01%) 371,201k (± 0.01%) ~ 371,142k 371,251k p=0.936 n=6
Parse Time 2.92s (± 0.60%) 2.88s (± 0.76%) -0.04s (- 1.26%) 2.85s 2.91s p=0.019 n=6
Bind Time 1.59s (± 1.17%) 1.59s (± 1.52%) ~ 1.57s 1.64s p=0.806 n=6
Check Time 16.51s (± 0.39%) 16.53s (± 0.23%) ~ 16.48s 16.58s p=0.872 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.02s (± 0.27%) 21.00s (± 0.22%) ~ 20.93s 21.07s p=0.467 n=6
vscode - node (v18.15.0, x64)
Errors 7 7 ~ ~ ~ p=1.000 n=6
Symbols 3,271,759 3,271,759 ~ ~ ~ p=1.000 n=6
Types 1,107,642 1,107,642 ~ ~ ~ p=1.000 n=6
Memory used 3,335,848k (± 0.00%) 3,335,745k (± 0.01%) ~ 3,335,409k 3,335,895k p=0.471 n=6
Parse Time 14.47s (± 0.78%) 14.52s (± 0.84%) ~ 14.31s 14.63s p=0.335 n=6
Bind Time 4.69s (± 2.16%) 4.69s (± 2.43%) ~ 4.61s 4.91s p=0.936 n=6
Check Time 91.25s (± 1.67%) 90.26s (± 1.93%) ~ 88.00s 92.50s p=0.378 n=6
Emit Time 28.91s (± 0.53%) 29.02s (± 1.86%) ~ 28.60s 30.10s p=1.000 n=6
Total Time 139.32s (± 1.03%) 138.49s (± 1.61%) ~ 135.67s 141.76s p=0.471 n=6
webpack - node (v18.15.0, x64)
Errors 31 31 ~ ~ ~ p=1.000 n=6
Symbols 295,227 295,227 ~ ~ ~ p=1.000 n=6
Types 120,606 120,606 ~ ~ ~ p=1.000 n=6
Memory used 449,293k (± 0.02%) 449,254k (± 0.02%) ~ 449,125k 449,396k p=0.471 n=6
Parse Time 4.06s (± 0.97%) 4.09s (± 0.89%) ~ 4.04s 4.15s p=0.228 n=6
Bind Time 1.77s (± 0.83%) 1.75s (± 1.11%) ~ 1.74s 1.79s p=0.073 n=6
Check Time 19.02s (± 0.39%) 19.09s (± 0.40%) ~ 19.03s 19.23s p=0.199 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.86s (± 0.28%) 24.94s (± 0.32%) ~ 24.82s 25.05s p=0.124 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 560,942 560,942 ~ ~ ~ p=1.000 n=6
Types 187,848 187,848 ~ ~ ~ p=1.000 n=6
Memory used 497,891k (± 0.01%) 497,671k (± 0.04%) ~ 497,511k 498,064k p=0.066 n=6
Parse Time 3.41s (± 0.19%) 3.43s (± 0.66%) ~ 3.40s 3.46s p=0.134 n=6
Bind Time 1.22s (± 0.96%) 1.21s (± 1.14%) ~ 1.19s 1.23s p=0.117 n=6
Check Time 19.72s (± 0.39%) 19.79s (± 0.32%) ~ 19.69s 19.85s p=0.147 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 24.34s (± 0.29%) 24.43s (± 0.25%) ~ 24.33s 24.49s p=0.065 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Mar 07 '25 20:03 typescript-bot

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61372/merge:

Everything looks good!

typescript-bot avatar Mar 07 '25 21:03 typescript-bot