Jake Bailey

Results 1452 comments of Jake Bailey

Yeah, you shouldn't do that. Run the tests then run `hereby baseline-accept`. https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines

@armanio123 seems like something broke.

Ah, you're on an M1 mac, so there's no such thing as a Node 8 binary. Unfortunately I'm not sure if I can fix this; older versions of TS just...

Hm, it shouldn't have needed that old version to build 4.9, no...

Thanks for the report! I obviously couldn't test every single commit before publishing it 😄 Just to write down my thoughts, the unlink is a red herring; that path is...

> Now maybe you have some more machinery in place than just trusting the `package.json` but there's no `package-lock.json` AND `@types/node` has the pretty useless version of `latest`. I do,...

> Testing this specific commit isn't that important to me, you could always maintain a list of not working commits if you want? They'd of course have to be excluded...

I'm not surprised that so many don't work; the repo only started merge via squash a few years ago.

Awesome! I really appreciate this data. I have some hope that I can fix some of these, but I suspect a bunch are just WIP commits from long ago (which...

> I still have the logs and timing information for every individual commit but I haven't uploaded those because they're a lot larger and mostly boring. I'd of course be...