Jake Bailey comments

Results 1472 comments of


                                            Jake Bailey

TypeScript-Go Performance Issue in ci (github action)

I'll note that the GHA runners are not particularly fast.

TypeScript-Go Performance Issue in ci (github action)

Everyone is posting different problems in this thread. If you are having perf issues, I would suggest opening a new issue and also uploading the profiles created by --pprofDir.

fix: Enable getExePath to work on Node 16

I guess we could do this, but you should also update `package.json`'s engines.

fix: Enable getExePath to work on Node 16

There is, in `_packages/native-preview/package.json`.

tsgo does not detect unreachable code

I think it does detect the unreachable code, it's just that the diagnostics code isn't setting that info on its response.

tsgo does not detect unreachable code

Hah, no, we're missing a bunch of related diagnostic stuff.

Folding range crash in JS file for `exports.property = CallExpression(ObjectLiteral)`

Yes, I think the astnav caching is incorrect given it's only based on positions

Organize imports for TypeScript and JavaScript

I don't think this is the right approach. The language server protocol already has organize imports. We should not require anything custom to make this work. Adding anything to the...

Organize imports for TypeScript and JavaScript

That's fair, thanks. I'm not totally sure how to do this nicely when the same command is registered by the main TS extension...

Organize imports for TypeScript and JavaScript

It's been a while, sorry. You probably want to merge with main and then see if anything you've done here has already been done on main. I see a bunch...