Jake Bailey

Results 1452 comments of Jake Bailey

If it was a mistake, I don't think we'd be against fixing it. If you make that change, we can run the extended tests and see how bad it would...

I've had a go at this in #56072 (whose build should appear shortly). But, I don't think my change is quite sound yet. Fundamentally though, this is a combinatorial explosion...

This is of your real upstream example, or just of the toy example? Can you also check 4.8? I think your other issue would show the first bump; what I'm...

In text form, that's: - 4.6: 30.0s - 4.8: 55.9s - 5.2: 69.3s - PR: 53.2s The PR makes it 30% faster, but going from 4.8 to 4.6 would bn...

`--generateTrace` doesn't always get very fine-grained; can you try https://www.npmjs.com/package/pprof-it and throw it into https://www.speedscope.app/ ? Or, send me the file?

Hm, so my PR effectively removes this entire bit, yes? I guess I did recover all of the time, and the other slowdowns on main relative to 4.6 are unrelated.

FWIW if this is code related to your work, like I said before, I think we can do an NDA (or, reuse an existing one if there's already one filed);...

FWIW I actually assumed that we already had one or something but if we don't then it's not a big deal; I tried to look and it was unclear to...

Do you have a reproduction you could share? These kinds of issues are hard to fix without a specific case to test, but maybe your case is the same as...

> If anyone come over here, I'd appreciate some help to fix the formating of `tests/baselines/reference/linkTagEmit1.js`, thank you in advance. Looks like a line ending problem. Did you use the...