Jake Bailey comments

Results 1452 comments of


                                            Jake Bailey

Isolated declarations does not handle object getters and setters with different types

Yeah, TS internally has no notion of a "set only property", see https://github.com/microsoft/TypeScript/issues/58112 and https://github.com/microsoft/TypeScript/issues/58119 (Void is definitely not the right answer, though)

Error: Debug Failure when importing `AssertionError` from `node:assert/strict`

The above test crashes even in TS 4.5 (and back even in 4.0 though with a slightly different error). So this most definitely is not a recent regression at all.

Duplicate imports do not have a consistent ordering

I think it may be sufficient to just put the namespace import before a named/default import, actually. If you're importing with names but twice, that's weird and probably pointless as...

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build

@typescript-bot perf test this faster

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build

Is this the winning PR or is #58593 still something to consider? Just checking before I review...

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build

I don't think that it is guaranteed; I almost made the playground always set forceDtsEmit because it always needs to show it (playground used to crash on dts errors), though...

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build

Isn't it public via `getEmitOutput` #34495? Or does that not matter?

Skip typechecking for files with no check in them even with dts emit

#58364 is in, so is this safe to update and get in?

Treat contextually typed functions in JS files as typed

@typescript-bot test top200 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this @typescript-bot pack this

Treat contextually typed functions in JS files as typed

@typescript-bot test it