Jake Bailey comments

Results 1446 comments of


                                            Jake Bailey

Infer AssertsIdentifier type predicates

@typescript-bot test it @typescript-bot pack this

Improve reuse of nodes in signatures with type mapping

@typescript-bot test it

Improve reuse of nodes in signatures with type mapping

Used your tool to review all 201 significantly changed files. Some notes: These are examples of notably good changes (good enough to point out how good they are): - declarationEmitGlobalThisPreserved.ts...

Improve reuse of nodes in signatures with type mapping

> I investigated and the way the signature is printed is different. The types base-line prints the types using the `GenerateNamesForShadowedTypeParams` flag, while the quick info does not use this...

Infer type predicates for functions with multiple returns

@typescript-bot test it

Infer type predicates for functions with multiple returns

@typescript-bot test top800

Infer type predicates for functions with multiple returns

@typescript-bot test it

Regular Expression finds

> @nostalic OMG, that’s totally my fault, I am very bad. I made it empty because the `Script_Extensions` section in [PropertyValueAliases.txt](https://www.unicode.org/Public/UCD/latest/ucd/PropertyValueAliases.txt) shows nothing, without thinking much. However, I don’t think...

Regular Expression finds

No, the type system does not special case regexes like this. (yet?)

Isolated declarations does not handle object getters and setters with different types

I feel like we just talked about this in a recent design meeting or something; IMO we should be preserving things as-written and not be doing our merging thing anymore.