Jake Bailey comments

Results 1446 comments of


                                            Jake Bailey

Crashing when project path contains Chinese characters.

A full backtrace would be helpful.

Folding Ranges implementation

This unfortunately crashed on me when I opened into `checker.ts`: ``` [Error - 10:32:43 AM] Request textDocument/foldingRange failed. Message: InternalError: panic handling request textDocument/foldingRange: Token cache mismatch: parent. Expected parent...

Folding Ranges implementation

Since I pushed, I can't review anymore. Can someone else look?

Folding Ranges implementation

Please file an issue with at least the panic stack trace.

Sourcemap generation consuming significant resources while sourcemaps are disabled

What is your full config? Do you have inlineSourceMaps enabled? Everything I'm reading implies this code should not be running if source maps are enabled. Though, the perf here is...

Sourcemap generation consuming significant resources while sourcemaps are disabled

There's no reason whatsoever why this code should even be active for you. It would be very helpful if there were a repro of this that were public (or, something...

Sourcemap generation consuming significant resources while sourcemaps are disabled

Probably, yes, though it just means we need to get another repo with dts source map emit enabled so we can go faster here. We benefited greatly in TS when...

Fix #1034: Improve symlink resolution in module specifier generation

This should be marked as fixing #1034, yes?

Fix #1034: Improve symlink resolution in module specifier generation

I think I expected the PR to be fixing a bunch of other symlink related issues in the fourslash tests, so I'm not sure what else we are missing. Maybe...