Jake Bailey

Results 1407 comments of Jake Bailey

We usually don't create tests for `lib.d.ts` like was done here; they're pretty annoying because they are typically very sensitive to tweaks, new lib.d.ts, etc. I think I missed this...

I know there are existing polyfills for Temporal out there in TS; are these types compatible / based off of those? Or fresh?

@typescript-bot test it

We don't control this; is VS Code / the LSP client not opening that file and asking for diagnostics?

Yes, we currently exclusively use pull diagnostic, which was how tsserver worked before, too. The TS extension then made the calls to ask for errors, so perhaps it already solved...

@typescript-bot user test this @typescript-bot run dt @typescript-bot test top800

@Renegade334 Do these differences seem correct to you? I think these are a result of the change you just made.

@typescript-bot test it

Hm, I guess the generated `Navigator` is missing a few things

this PR contains random unrelated changes from another PR