Jake Bailey
Jake Bailey
@maschwenk I think I want to try to get this in, just so we can have people try this and see how it behaves. The current code looks fine, though...
`typeRoots` just affects how `@types` resolution proceeds; which dirs to look for `@types` in (the "type roots"). https://www.typescriptlang.org/tsconfig/#typeRoots But this doesn't allow you to place your own files before others;...
If the types are wrong, can you send PRs to DT to fix them, or file discussions there? Or bring them up in the DT channel on the discord? In...
FWIW you do not need tests for this kind of change; it's honestly worse to write tests for these comments because updating them later will mean having to update tests...
Ha, I didn't notice my own comment from before; at least I'm consistent. But, please do remove all changes except those in `es5.d.ts`.
@typescript-bot test top200 @typescript-bot user test this @typescript-bot run dt @typescript-bot perf test this @typescript-bot pack this
@typescript-bot test it @typescript-bot pack this
Do you have a repo where this reproduces?
This codebase isn't in JS, so the runtime you use to run it cannot be the problem
That setting does not apply when using the native preview extension. Node is never involved in launching the language server in the new codebase. If that setting matters, I don't...