Jake Bailey
Jake Bailey
It's not incorrect; it's definitely not thoroughly tested. We're not even claiming JS/JSDoc is done, so it would be weird to say that its declaration emit is already done.
Sad there's no test but it's correct, so
Yeah, it makes separate baselines, so is a pretty good solution to this.
I don't see any evidence in the linked page either. @Darkproduct what is motivating this change?
Then it seems like you should be adding that as a test. But, this to me implies that the data could be basically _anything_, no? Like, it could be 4D,...
Okay; can you add a test, though?
The test can just be the code you've written, such that it doesn't work before your PR but does work after.
This introduces a data race. I'm not sure `includeProcessor` is safe for concurrent use, yet the existing code appears to already touch this concurrently and I think that is likely...
@copilot See above. Make `includeProcessor` safe for concurrent use.
@copilot Address the comments