Diagnostics not shown in file peek views

[mjbvz]

1. Create two files:

// abc.ts
/**
 * @deprecated
 */
export function abc() { }
abc();

// other.ts
import { abc } from "./abc";

abc()
xyz;

2. With only abc.ts open, run peek references on abc (you can also use the references codelens for this)

Bug In the peek view, no diagnostics are shown

They are shown with TS 6.0

[jakebailey]

We don't control this; is VS Code / the LSP client not opening that file and asking for diagnostics?

[mjbvz]

Yes maybe an lsp issue? cc @dbaeumer

[dbaeumer]

VS Code and LSP issue :-(. I assume the new TS extension uses pull diagnostics. We pull for open editor tabs and I guess that VS Code is not representing editors in peek views in the tab model. @lramos15 is there a way to know about these peek editor tabs?

[jakebailey]

Yes, we currently exclusively use pull diagnostic, which was how tsserver worked before, too. The TS extension then made the calls to ask for errors, so perhaps it already solved this issue once before?

[lramos15]

@lramos15 is there a way to know about these peek editor tabs?

I'm not sure maybe @bpasero knows. I don't think the tabs API is the right place to represent this, unless we have that be a member property on a tab since we want tabs to represent logical UI tabs. Maybe the text document API is better here?

[bpasero]

@jrieken might have guidance

[jrieken]

Peek editors aren't tab-editors and I think the visible editors route needs to be taken here.