TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

DOM update 2025-12-10

Open jakebailey opened this issue 1 month ago • 13 comments

Pulling in the latest since a bunch changed.

jakebailey avatar Nov 07 '25 05:11 jakebailey

@typescript-bot user test this @typescript-bot run dt @typescript-bot test top800

jakebailey avatar Nov 07 '25 05:11 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
test top800 ✅ Started 👀 Results

typescript-bot avatar Nov 07 '25 05:11 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: serviceworker-webpack-plugin Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/serviceworker-webpack-plugin/serviceworker-webpack-plugin-tests.ts
  49:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect
  53:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot avatar Nov 07 '25 06:11 typescript-bot

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62730/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot avatar Nov 07 '25 06:11 typescript-bot

@jakebailey Here are the results of running the top 800 repos with tsc comparing main and refs/pull/62730/merge:

Something interesting changed - please have a look.

Details

microsoft/azuredatastudio

44 of 67 projects failed to build with the old tsc and were ignored

extensions/vscode-test-resolver/tsconfig.json

microsoft/vscode

13 of 63 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/vscode-test-resolver/tsconfig.json

build/checker/tsconfig.electron-browser.json

typescript-bot avatar Nov 07 '25 08:11 typescript-bot

@Renegade334 Do these differences seem correct to you? I think these are a result of the change you just made.

jakebailey avatar Nov 11 '25 19:11 jakebailey

The top800 ones? Those do look correct – these are essentially the exact same ArrayBufferView<ArrayBufferLike>-to-ArrayBufferView<ArrayBuffer> assignability errors that were unearthed in 5.9 in the rest of the library, but an erroneous override on WebSocket#send() shielded the effects from this specific method.

Renegade334 avatar Nov 11 '25 20:11 Renegade334

@typescript-bot test it

jakebailey avatar Dec 11 '25 01:12 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

typescript-bot avatar Dec 11 '25 01:12 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-navigation Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-navigation/dom-navigation-tests.ts
  49:12  error  TypeScript@local compile error: 
Property 'onnavigate' does not exist on type 'Navigation'. Did you mean 'navigate'?                                                                                                                                                                                                                                                                                                                                                          @definitelytyped/expect
  50:41  error  TypeScript@local compile error: 
Argument of type '(e: NavigateEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject | null'.
  Type '(e: NavigateEvent) => void' is not assignable to type 'EventListener'.
    Types of parameters 'e' and 'evt' are incompatible.
      Type 'Event' is missing the following properties from type 'NavigateEvent': canIntercept, destination, downloadRequest, formData, and 9 more                  @definitelytyped/expect
  51:44  error  TypeScript@local compile error: 
Argument of type '(e: NavigateEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject | null'.
  Type '(e: NavigateEvent) => void' is not assignable to type 'EventListener'.
    Types of parameters 'e' and 'evt' are incompatible.
      Type 'Event' is missing the following properties from type 'NavigateEvent': canIntercept, destination, downloadRequest, formData, and 9 more                  @definitelytyped/expect
  53:12  error  TypeScript@local compile error: 
Property 'onnavigatesuccess' does not exist on type 'Navigation'                                                                                                                                                                                                                                                                                                                                                                             @definitelytyped/expect
  57:12  error  TypeScript@local compile error: 
Property 'onnavigateerror' does not exist on type 'Navigation'                                                                                                                                                                                                                                                                                                                                                                               @definitelytyped/expect
  64:12  error  TypeScript@local compile error: 
Property 'oncurrententrychange' does not exist on type 'Navigation'                                                                                                                                                                                                                                                                                                                                                                          @definitelytyped/expect
  65:51  error  TypeScript@local compile error: 
Argument of type '(e: NavigationCurrentEntryChangeEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject | null'.
  Type '(e: NavigationCurrentEntryChangeEvent) => void' is not assignable to type 'EventListener'.
    Types of parameters 'e' and 'evt' are incompatible.
      Type 'Event' is missing the following properties from type 'NavigationCurrentEntryChangeEvent': from, navigationType  @definitelytyped/expect
  66:54  error  TypeScript@local compile error: 
Argument of type '(e: NavigationCurrentEntryChangeEvent) => void' is not assignable to parameter of type 'EventListenerOrEventListenerObject | null'.
  Type '(e: NavigationCurrentEntryChangeEvent) => void' is not assignable to type 'EventListener'.
    Types of parameters 'e' and 'evt' are incompatible.
      Type 'Event' is missing the following properties from type 'NavigationCurrentEntryChangeEvent': from, navigationType  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-navigation/index.d.ts
   13:5   error  TypeScript@local compile error: 
All declarations of 'committed' must have identical modifiers                                                                                                                                       @definitelytyped/expect
   13:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'committed' must be of type 'Promise<NavigationHistoryEntry> | undefined', but here has type 'Promise<NavigationHistoryEntry>'  @definitelytyped/expect
   14:5   error  TypeScript@local compile error: 
All declarations of 'finished' must have identical modifiers                                                                                                                                        @definitelytyped/expect
   14:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<NavigationHistoryEntry> | undefined', but here has type 'Promise<NavigationHistoryEntry>'   @definitelytyped/expect
   17:15  error  TypeScript@local compile error: 
Duplicate identifier 'Navigation'                                                                                                                                                                   @definitelytyped/expect
   60:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigationTransition'                                                                                                                                                         @definitelytyped/expect
  111:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'state' must be of type 'any', but here has type 'unknown'                                                                      @definitelytyped/expect
  115:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'info' must be of type 'any', but here has type 'unknown'                                                                       @definitelytyped/expect
  119:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'state' must be of type 'any', but here has type 'unknown'                                                                      @definitelytyped/expect
  124:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'state' must be of type 'any', but here has type 'unknown'                                                                      @definitelytyped/expect
  127:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigationCurrentEntryChangeEvent'                                                                                                                                            @definitelytyped/expect
  139:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigateEvent'                                                                                                                                                                @definitelytyped/expect
  166:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'info' must be of type 'any', but here has type 'unknown'                                                                       @definitelytyped/expect
  170:5   error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'handler' must be of type 'NavigationInterceptHandler | undefined', but here has type '(() => Promise<void>) | undefined'       @definitelytyped/expect
  175:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigationDestination'                                                                                                                                                        @definitelytyped/expect

✖ 23 problems (23 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

Package: serviceworker-webpack-plugin Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/serviceworker-webpack-plugin/serviceworker-webpack-plugin-tests.ts
  49:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect
  53:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

typescript-bot avatar Dec 11 '25 01:12 typescript-bot

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62730/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot avatar Dec 11 '25 01:12 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,387 50,387 ~ ~ ~ p=1.000 n=6
Memory used 195,054k (± 0.95%) 194,979k (± 0.93%) ~ 192,517k 196,233k p=0.378 n=6
Parse Time 1.30s (± 0.76%) 1.30s (± 0.42%) ~ 1.30s 1.31s p=0.232 n=6
Bind Time 0.76s 0.76s (± 0.54%) ~ 0.76s 0.77s p=0.405 n=6
Check Time 9.84s (± 0.46%) 9.85s (± 0.23%) ~ 9.81s 9.87s p=0.292 n=6
Emit Time 2.74s (± 0.76%) 2.73s (± 0.64%) ~ 2.72s 2.76s p=0.560 n=6
Total Time 14.63s (± 0.33%) 14.65s (± 0.19%) ~ 14.61s 14.69s p=0.467 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 955,823 956,181 +358 (+ 0.04%) ~ ~ p=0.001 n=6
Types 415,853 415,960 +107 (+ 0.03%) ~ ~ p=0.001 n=6
Memory used 1,253,891k (± 0.01%) 1,254,976k (± 0.00%) +1,085k (+ 0.09%) 1,254,938k 1,255,027k p=0.005 n=6
Parse Time 6.54s (± 0.67%) 6.57s (± 0.43%) ~ 6.52s 6.60s p=0.225 n=6
Bind Time 1.96s (± 0.32%) 1.96s (± 0.21%) ~ 1.95s 1.96s p=0.673 n=6
Check Time 32.30s (± 0.56%) 32.38s (± 0.12%) ~ 32.33s 32.44s p=0.748 n=6
Emit Time 14.94s (± 0.32%) 15.01s (± 0.52%) ~ 14.91s 15.08s p=0.128 n=6
Total Time 55.74s (± 0.36%) 55.91s (± 0.17%) ~ 55.78s 56.07s p=0.173 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,723,733 2,724,059 +326 (+ 0.01%) ~ ~ p=0.001 n=6
Types 937,508 937,620 +112 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,051,278k (± 0.00%) 3,052,194k (± 0.00%) +916k (+ 0.03%) 3,052,129k 3,052,259k p=0.005 n=6
Parse Time 8.60s (± 0.32%) 8.60s (± 0.39%) ~ 8.56s 8.66s p=0.685 n=6
Bind Time 2.31s (± 0.33%) 2.30s (± 0.48%) ~ 2.28s 2.31s p=0.062 n=6
Check Time 93.06s (± 0.54%) 93.17s (± 0.42%) ~ 92.75s 93.74s p=0.471 n=6
Emit Time 0.31s (± 2.66%) 0.31s (± 2.04%) ~ 0.30s 0.32s p=0.432 n=6
Total Time 104.28s (± 0.49%) 104.37s (± 0.39%) ~ 103.93s 105.02s p=0.575 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,252,077 1,252,077 ~ ~ ~ p=1.000 n=6
Types 259,856 259,856 ~ ~ ~ p=1.000 n=6
Memory used 2,998,772k (± 9.90%) 2,876,294k (±13.07%) ~ 2,389,567k 3,119,963k p=0.066 n=6
Parse Time 6.59s (± 1.10%) 6.57s (± 1.15%) ~ 6.45s 6.65s p=0.688 n=6
Bind Time 2.24s (± 0.88%) 2.24s (± 0.96%) ~ 2.21s 2.27s p=0.872 n=6
Check Time 42.83s (± 0.46%) 42.70s (± 0.48%) ~ 42.33s 42.88s p=0.471 n=6
Emit Time 3.46s (± 2.09%) 3.52s (± 3.45%) ~ 3.37s 3.72s p=0.261 n=6
Total Time 55.12s (± 0.45%) 55.05s (± 0.47%) ~ 54.61s 55.41s p=0.689 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,252,077 1,252,077 ~ ~ ~ p=1.000 n=6
Types 259,856 259,856 ~ ~ ~ p=1.000 n=6
Memory used 3,061,563k (± 9.65%) 3,182,907k (± 0.03%) ~ 3,181,853k 3,184,235k p=0.173 n=6
Parse Time 6.77s (± 1.29%) 6.79s (± 0.96%) ~ 6.70s 6.90s p=0.810 n=6
Bind Time 2.25s (± 1.18%) 2.26s (± 0.86%) ~ 2.23s 2.28s p=0.630 n=6
Check Time 43.08s (± 0.38%) 43.22s (± 0.51%) ~ 42.79s 43.41s p=0.230 n=6
Emit Time 3.50s (± 1.65%) 3.52s (± 2.39%) ~ 3.40s 3.66s p=1.000 n=6
Total Time 55.63s (± 0.45%) 55.78s (± 0.41%) ~ 55.34s 55.96s p=0.298 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 264,690 264,690 ~ ~ ~ p=1.000 n=6
Types 104,069 104,069 ~ ~ ~ p=1.000 n=6
Memory used 442,857k (± 0.02%) 442,768k (± 0.01%) -89k (- 0.02%) 442,714k 442,804k p=0.045 n=6
Parse Time 2.83s (± 0.29%) 2.85s (± 0.62%) ~ 2.82s 2.87s p=0.216 n=6
Bind Time 1.16s 1.16s (± 0.35%) ~ 1.16s 1.17s p=0.405 n=6
Check Time 16.06s (± 0.31%) 16.05s (± 0.38%) ~ 15.96s 16.13s p=0.810 n=6
Emit Time 1.32s (± 1.25%) 1.32s (± 1.62%) ~ 1.28s 1.34s p=0.461 n=6
Total Time 21.37s (± 0.24%) 21.37s (± 0.32%) ~ 21.29s 21.46s p=1.000 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,493 225,493 ~ ~ ~ p=1.000 n=6
Types 94,373 94,373 ~ ~ ~ p=1.000 n=6
Memory used 369,816k (± 0.01%) 369,760k (± 0.02%) ~ 369,702k 369,831k p=0.173 n=6
Parse Time 2.81s (± 1.30%) 2.82s (± 1.24%) ~ 2.77s 2.87s p=1.000 n=6
Bind Time 1.66s (± 1.28%) 1.64s (± 0.83%) ~ 1.63s 1.67s p=0.179 n=6
Check Time 16.59s (± 0.52%) 16.52s (± 0.44%) ~ 16.42s 16.61s p=0.226 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.07s (± 0.45%) 20.98s (± 0.43%) ~ 20.84s 21.11s p=0.172 n=6
vscode - node (v18.15.0, x64)
Errors 11 12 🔻+1 (+ 9.09%) ~ ~ p=0.001 n=6
Symbols 4,077,233 4,077,814 +581 (+ 0.01%) ~ ~ p=0.001 n=6
Types 1,285,112 1,285,323 +211 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 3,864,609k (± 0.00%) 3,865,562k (± 0.00%) +953k (+ 0.02%) 3,865,366k 3,865,731k p=0.005 n=6
Parse Time 15.69s (± 0.43%) 15.74s (± 0.23%) ~ 15.71s 15.81s p=0.090 n=6
Bind Time 5.35s (± 1.93%) 5.31s (± 0.51%) ~ 5.28s 5.35s p=0.625 n=6
Check Time 115.74s (± 4.24%) 111.68s (± 1.44%) ~ 110.10s 114.49s p=0.128 n=6
Emit Time 48.10s (± 8.39%) 41.88s (±12.61%) 🟩-6.22s (-12.92%) 37.45s 52.15s p=0.045 n=6
Total Time 184.88s (± 3.47%) 174.62s (± 2.77%) 🟩-10.26s (- 5.55%) 170.45s 183.73s p=0.020 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 380,693 381,125 +432 (+ 0.11%) ~ ~ p=0.001 n=6
Types 166,792 166,964 +172 (+ 0.10%) ~ ~ p=0.001 n=6
Memory used 539,543k (± 0.01%) 540,581k (± 0.03%) +1,038k (+ 0.19%) 540,313k 540,726k p=0.005 n=6
Parse Time 4.71s (± 0.58%) 4.70s (± 0.75%) ~ 4.66s 4.76s p=0.747 n=6
Bind Time 2.07s (± 1.73%) 2.05s (± 1.79%) ~ 1.99s 2.10s p=0.687 n=6
Check Time 23.01s (± 0.38%) 23.03s (± 0.33%) ~ 22.92s 23.11s p=0.688 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 29.79s (± 0.29%) 29.79s (± 0.31%) ~ 29.62s 29.88s p=0.809 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 693,864 694,109 +245 (+ 0.04%) ~ ~ p=0.001 n=6
Types 211,665 211,698 +33 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 589,092k (± 0.02%) 590,069k (± 0.04%) +977k (+ 0.17%) 589,868k 590,345k p=0.005 n=6
Parse Time 4.20s (± 0.36%) 4.17s (± 0.60%) ~ 4.15s 4.22s p=0.107 n=6
Bind Time 1.42s (± 0.74%) 1.41s (± 1.08%) ~ 1.38s 1.42s p=0.282 n=6
Check Time 21.47s (± 2.14%) 21.41s (± 1.94%) ~ 20.84s 21.73s p=0.810 n=6
Emit Time 0.00s (±154.76%) 0.00s (±244.70%) ~ 0.00s 0.01s p=0.595 n=6
Total Time 27.09s (± 1.71%) 26.99s (± 1.46%) ~ 26.44s 27.28s p=0.689 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Dec 11 '25 02:12 typescript-bot

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62730/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

11 of 63 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/vscode-test-resolver/tsconfig.json

build/checker/tsconfig.electron-browser.json

typescript-bot avatar Dec 11 '25 02:12 typescript-bot

Hm, I guess the generated Navigator is missing a few things

jakebailey avatar Dec 11 '25 21:12 jakebailey

Hm, I guess the generated Navigator is missing a few things

It's the new Naviga​tion API that @types/dom-navigation is clashing with.

Renegade334 avatar Dec 12 '25 23:12 Renegade334