Iván Valdés Castillo
Iván Valdés Castillo
@Elbehery, we don't have a `shellcheck` CI check here (yet). Can you run shellcheck on your script? I believe there are a couple of instances where it will give warnings...
> Sorry for the late response. @ivanvc is this PR good to go? No, we're missing changes from the last batch of comments. The script, as it is right now,...
Thanks for the changes, @Elbehery. I'll test locally in my fork and then provide a review.
Cross-posting https://github.com/etcd-io/bbolt/pull/895#issuecomment-2643455324 > Hi @Elbehery and @ahrtr. Given the size of this project, goreleaser may be a good fit. Refer to etcd-io/auger#136.
Is there any path forward with this pull request? We're also migrating from fluentd, and this field is missing in fluent bit. It would be great to get some feedback...
> I'll give this a go! I will make a pr today or tmrw. I wanted to know how the gifs are uploaded to google store. @jmhbnz Hi, @NavinShrinivas. The...
Hi @romainwg and @NavinShrinivas. I reviewed both of your pull requests. I wouldn't say that one is correct (or better than the other one). But it definitely adds contention to...
~~@jmhbnz should we reopen because of #908?~~ Nevermind 😅
Discussed during the fortnightly triage meeting. @moficodes to review.