etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Revision auto compaction should have configurable timer instead of fixed 5 minute timer

Open jrcichra opened this issue 1 year ago • 4 comments

What would you like to be added?

Today the revision auto compaction has a constant 5 minute compaction. Change this to be a command-line / environment variable configurable option.

Why is this needed?

With enough key revisions per second, the constant 5 minute interval on revision compaction isn't fast enough to keep up with growth. Consider making the interval configurable, which will override the default behavior of 5 minutes.

jrcichra avatar Aug 19 '24 19:08 jrcichra

I would like to work on this issue.

parthlaw avatar Aug 19 '24 21:08 parthlaw

I would like to work on this issue.

Hey @parthlaw , I have an implementation here I made along with the issue: https://github.com/etcd-io/etcd/pull/18472. Let me know what you think!

jrcichra avatar Aug 20 '24 03:08 jrcichra

Thanks for the update @jrcichra . I am looking into the implementation. This is a great learning opportunity for me—Thanks for the guidance!

parthlaw avatar Aug 20 '24 18:08 parthlaw

Discussed during the fortnightly triage meeting. @moficodes to review.

ivanvc avatar Aug 29 '24 18:08 ivanvc

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 06:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 24 '25 00:09 github-actions[bot]