Trevor Clinkenbeard comments

Repositories
Issues
Comments

Results 5 comments of


                                            Trevor Clinkenbeard

Move `StorageServerDisk` code to separate files

This passed 100k Joshua runs: `20230206-034159-tclinkenbeard-74af3b8a5f702a2e`.

Fix clang-tidy string warnings

Thanks, this PR will be very helpful.

StorageMetrics.BytesStored estimate excludes the StorageServer's private keyspace

This sounds like a good new metric to add. I think we should keep around the old `StorageMetrics.BytesStored` as well, because non-private data is important for data distribution. Maybe we...

Support non-string value fields in JSON tracing

@fdb-build test this please

Support non-string value fields in JSON tracing

> My preference for how we would do this would be that we would not convert the objects to strings in the JSON-style, but rather allow the formatter in use...