foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

Fix clang-tidy string warnings

Open AZero13 opened this issue 2 years ago • 32 comments

These changes greatly simplify the code and makes the intent more clear.

AZero13 avatar Dec 11 '22 00:12 AZero13

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: cda654678b5d4fc7353dbf5aff62342dbe965e0b
  • Duration 0:06:15
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 0:07:33
  • Result: :x: FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: cda654678b5d4fc7353dbf5aff62342dbe965e0b
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Dec 11 '22 01:12 fdb-windows-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: cda654678b5d4fc7353dbf5aff62342dbe965e0b
  • Duration 0:17:52
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 0:20:03
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 0:44:08
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: ba0cca42b970b13626469705864114e9d6072be0
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Dec 11 '22 01:12 fdb-windows-ci

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 0:53:06
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: ba0cca42b970b13626469705864114e9d6072be0
  • Duration 0:19:52
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 01:12 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: ba0cca42b970b13626469705864114e9d6072be0
  • Duration 0:24:03
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: ba0cca42b970b13626469705864114e9d6072be0
  • Duration 0:31:25
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: cda654678b5d4fc7353dbf5aff62342dbe965e0b
  • Duration 1:16:29
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 1:24:56
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Result: :x: FAILED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Dec 11 '22 02:12 fdb-windows-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 672e84479f8f7d8c8d8542391bcee9f75859957e
  • Duration 1:30:16
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: cda654678b5d4fc7353dbf5aff62342dbe965e0b
  • Duration 1:29:32
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 0:18:47
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 0:26:23
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 0:31:45
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 0:43:21
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 02:12 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ba0cca42b970b13626469705864114e9d6072be0
  • Duration 1:21:47
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 03:12 foundationdb-ci

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 0:51:55
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 03:12 foundationdb-ci

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 77919639d6af1ffe6e0b61eb71d2f8a00fcec439
  • Duration 1:24:46
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

foundationdb-ci avatar Dec 11 '22 03:12 foundationdb-ci

Looks like there is a conflict now. Can you please resolve it?

jzhou77 avatar Jan 09 '23 17:01 jzhou77

Thanks, this PR will be very helpful.

sfc-gh-tclinkenbeard avatar Jan 09 '23 17:01 sfc-gh-tclinkenbeard

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 7f7f4009693370bea4f7dd76be7d20ff0e458111
  • Duration 0:19:36
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jan 10 '23 17:01 foundationdb-ci

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 7f7f4009693370bea4f7dd76be7d20ff0e458111
  • Duration 0:26:44
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jan 10 '23 17:01 foundationdb-ci

Doxense CI Report for Windows 10

  • Commit ID: 7f7f4009693370bea4f7dd76be7d20ff0e458111
  • Result: :heavy_check_mark: SUCCEEDED
  • Build Logs (available for 30 days)

fdb-windows-ci avatar Jan 10 '23 17:01 fdb-windows-ci

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 7f7f4009693370bea4f7dd76be7d20ff0e458111
  • Duration 0:32:04
  • Result: :x: FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jan 10 '23 17:01 foundationdb-ci

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

  • Commit ID: 7f7f4009693370bea4f7dd76be7d20ff0e458111
  • Duration 0:43:09
  • Result: :white_check_mark: SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci avatar Jan 10 '23 17:01 foundationdb-ci