foundationdb icon indicating copy to clipboard operation
foundationdb copied to clipboard

StorageMetrics.BytesStored estimate excludes the StorageServer's private keyspace

Open sfc-gh-satherton opened this issue 2 years ago • 1 comments

StorageMetrics.BytesStored is an estimate of stored KV records in `` to \xff\xff which excludes the local private keyspace. With ChangeFeeds, this space might not be trivial in size, but also if any bug were to cause accumulation of data there it would not be accounted for.

sfc-gh-satherton avatar Nov 26 '22 00:11 sfc-gh-satherton

This sounds like a good new metric to add. I think we should keep around the old StorageMetrics.BytesStored as well, because non-private data is important for data distribution. Maybe we can add a StorageMetrics.PrivateBytesStored metric.

sfc-gh-tclinkenbeard avatar Nov 28 '22 18:11 sfc-gh-tclinkenbeard