This is the first part of an attempt to shrink the size of storageserver.actor.cpp, by separating out components into their own independent files, with clear public interfaces for each component. 3 new files are created:

• StorageServer.h
• StorageServerDisk.h
• StorageServerDisk.actor.cpp

These files have the following dependencies:

• storageserver.actor.cpp including StorageServer.h
• StorageServer.h and StorageServerDisk.actor.cpp including StorageServerDisk.h

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

• [ ] The PR has a description, explaining both the problem and the solution.
• [ ] The description mentions which forms of testing were done and the testing seems reasonable.
• [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

• [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
• [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

Doxense CI Report for Windows 10

• Commit ID: 31daec622e2c8b8cd7c02b1d33c9887589d11697
• Result: :heavy_check_mark: SUCCEEDED
• Build Logs (available for 30 days)

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: 31daec622e2c8b8cd7c02b1d33c9887589d11697
• Duration 0:24:03
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Result of foundationdb-pr-clang-ide on Linux CentOS 7

• Commit ID: df08df98e8bad9daffb8f8951ab0d8cc2a69d443
• Duration 0:26:42
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

This passed 100k Joshua runs: 20230206-034159-tclinkenbeard-74af3b8a5f702a2e.

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: 31daec622e2c8b8cd7c02b1d33c9887589d11697
• Duration 1:18:20
• Result: :x: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: 31daec622e2c8b8cd7c02b1d33c9887589d11697
• Duration 1:18:52
• Result: :x: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Result of foundationdb-pr on Linux CentOS 7

• Commit ID: df08df98e8bad9daffb8f8951ab0d8cc2a69d443
• Duration 1:20:55
• Result: :x: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Result of foundationdb-pr-clang on Linux CentOS 7

• Commit ID: df08df98e8bad9daffb8f8951ab0d8cc2a69d443
• Duration 1:28:54
• Result: :x: FAILED
• Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: df08df98e8bad9daffb8f8951ab0d8cc2a69d443
• Duration 2:09:23
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

• Commit ID: 31daec622e2c8b8cd7c02b1d33c9887589d11697
• Duration 2:09:52
• Result: :white_check_mark: SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)
• Cluster Test Logs zip file of the test logs (available for 30 days)