seladb comments

Results 544 comments of


                                            seladb

Add SOME/IP protocol

> @seladb thx for the review, i currently will focus on NDP/ICMPv6 so there will be no progress here the next week Sure, no problem at all! Thanks for your...

Add SOME/IP SD protocol

@kolbex pre-commit fails because of spelling issues, can you please fix them?

Are there plans to support the ND (Neighbor Discovery) protocol in ICMPv6?

ICMPv6 is not yet supported in PcapPlusPlus, but you're more than welcome to add it 😃

Are there plans to support the ND (Neighbor Discovery) protocol in ICMPv6?

Sounds good, thank you! 🙏

Are there plans to support the ND (Neighbor Discovery) protocol in ICMPv6?

@angelyouyou any progress on this?

Are there plans to support the ND (Neighbor Discovery) protocol in ICMPv6?

@maruu sounds good, I really appreciate your contribution and support! 🙏

Heap buffer overflow (read) in DnsResource::getDataLength() at DnsResource.cpp:277:24

Thanks @vivin for reporting this issue! Would you consider opening PRs with fixes to this and the other 3 issues you found?

Heap buffer overflow (read) in DnsResource::getDataLength() at DnsResource.cpp:277:24

@vivin feel free to give it a shot! Given that you managed to find these issues using a fuzzer I'm sure you'll be able to fix them 😃

Heap buffer overflow (read) in IgmpLayer::getIGMPVerFromData(unsigned char*, unsigned long, bool&) at IgmpLayer.cpp:81:7

Hi @vivin ! In this issue and the other issues you opened you didn't specify the code you're running so I don't know how to reproduce them. Please provide the...

Heap buffer overflow (read) in RadiusLayer::isDataValid(unsigned char const*, unsigned long) at RadiusLayer.cpp:246:19

Hi @vivin ! In this issue and the other issues you opened you didn't specify the code you're running so I don't know how to reproduce them. Please provide the...