PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard

Heap buffer overflow (read) in IgmpLayer::getIGMPVerFromData(unsigned char*, unsigned long, bool&) at IgmpLayer.cpp:81:7

Open vivin opened this issue 3 years ago • 2 comments

There is a buffer overflow at the specified location:

==854686==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60400000f2b7 at pc 0x000000761fc0 bp 0x7fffe21bf0e0 sp 0x7fffe21bf0d8
READ of size 1 at 0x60400000f2b7 thread T0
    #0 0x761fbf in pcpp::IgmpLayer::getIGMPVerFromData(unsigned char*, unsigned long, bool&) /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Packet++/src/IgmpLayer.cpp:81:7
    #1 0x664147 in pcpp::IPv4Layer::parseNextLayer() /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Packet++/src/IPv4Layer.cpp:299:13
    #2 0x54a40b in pcpp::Packet::setRawPacket(pcpp::RawPacket*, bool, unsigned long, pcpp::OsiModelLayer) /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Packet++/src/Packet.cpp:80:13
    #3 0x54d82b in pcpp::Packet::Packet(pcpp::RawPacket*, bool, unsigned long, pcpp::OsiModelLayer) /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Packet++/src/Packet.cpp:126:2
    #4 0x4f33c3 in main /home/vivin/Projects/phd/resources/archives/pcapplusplus/readpcap.cpp:30:20
    #5 0x7fd8c90590b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
    #6 0x4441bd in _start (/home/vivin/Projects/phd/workspace/smartdsf/pcapplusplus/binaries/vanilla-asan/readpcap+0x4441bd)

0x60400000f2b7 is located 0 bytes to the right of 39-byte region [0x60400000f290,0x60400000f2b7)
allocated by thread T0 here:
    #0 0x4f05ed in operator new[](unsigned long) (/home/vivin/Projects/phd/workspace/smartdsf/pcapplusplus/binaries/vanilla-asan/readpcap+0x4f05ed)
    #1 0x4f942d in pcpp::PcapFileReaderDevice::getNextPacket(pcpp::RawPacket&) /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Pcap++/src/PcapFileDevice.cpp:306:27
    #2 0x4f3328 in main /home/vivin/Projects/phd/resources/archives/pcapplusplus/readpcap.cpp:28:17
    #3 0x7fd8c90590b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/vivin/Projects/phd/subjects/pcapplusplus/PcapPlusPlus-master/Packet++/src/IgmpLayer.cpp:81:7 in pcpp::IgmpLayer::getIGMPVerFromData(unsigned char*, unsigned long, bool&)
Shadow bytes around the buggy address:
  0x0c087fff9e00: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c087fff9e10: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c087fff9e20: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c087fff9e30: fa fa 00 00 00 00 00 fa fa fa 00 00 00 00 00 fa
  0x0c087fff9e40: fa fa 00 00 00 00 00 fa fa fa fd fd fd fd fd fa
=>0x0c087fff9e50: fa fa 00 00 00 00[07]fa fa fa fa fa fa fa fa fa
  0x0c087fff9e60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c087fff9e70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c087fff9e80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c087fff9e90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c087fff9ea0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==854686==ABORTING
Aborted

I have attached the input that triggers the vulnerability. igmplayer.pcap.zip

vivin avatar Mar 31 '22 16:03 vivin

Hi @vivin !

In this issue and the other issues you opened you didn't specify the code you're running so I don't know how to reproduce them. Please provide the code, otherwise I'm not sure what to do with it.

seladb avatar Apr 02 '22 07:04 seladb

Sorry about that. I have provided it in #856.

vivin avatar Apr 02 '22 08:04 vivin

Thank you @sashashura for providing a fix! 🙏

seladb avatar Dec 12 '22 08:12 seladb