seladb

We can definitely do it, but there is a demand for both platforms 😃

yes, this request has been discussed before here: https://github.com/seladb/PcapPlusPlus/issues/644. Right now it's not supported but if you want you're more than welcome to implement this feature. We can discuss what's...

This can be a good addition to this project. This is just for configuring ports, is that correct? I think we can let the user choose the location of the...

@weyrick thanks for reaching out! The issue is that there might be several layers of the same OSI layer. The most trivial example I can think of is multiple VLAN...

That's an interesting idea @weyrick ! Maybe this pure virtual method should return the protocol, the OSI layer, and an indicator of which layer to create? 🤔 That way it...

> although it means that adding new protocols requires changing this big createLayer() method Yes, this is a good point. Maybe we can consider adding this method outside of the...

> I actually prefer my first suggestion, just splitting the identification from the creation and adding an identifyNextLayer, but otherwise leaving the architecture. But this will create code duplication between...

hi @weyrick , yes this can be a nice refactoring. There is still some code duplication but I guess we can live with that

@weyrick that's a great idea, and a much cleaner solution! It will still require changes in each layer's `parseNextLayer()` to check if the next layer should be parsed, but as...

that makes sense @weyrick , thanks for letting me know. Let's keep this issue open for now, maybe someone will want to take it