MemPlumber icon indicating copy to clipboard operation
MemPlumber copied to clipboard

Add static checks

Open egecetin opened this issue 8 months ago • 6 comments

Requires #7

egecetin avatar Jul 10 '25 06:07 egecetin

@egecetin this PR contains a lot of changes and is hard to review. Is it possible to maybe split it into multiple smaller PRs? Maybe:

  • Run clang-format for different parts of the code (2-3 PRs)
  • Add basic pre-commit
  • Add typos & codespell
  • Add dependabot
  • Maybe more if I'm missing someinth?

seladb avatar Jul 24 '25 06:07 seladb

@seladb Most of them are whitespace changes and unfortunately GitHub renders it really bad. Did you try to use VSCode directly to take a look for changes? If I'm not mistaken GitHub Pull Requests extension but not sure. See screenshot below. If you still think review is hard I can split it off course

image

egecetin avatar Jul 24 '25 07:07 egecetin

Most of them clang-format change so I can split clang-format

egecetin avatar Jul 24 '25 07:07 egecetin

Most of them clang-format change so I can split clang-format

Maybe at least split clang-format from the rest so it's easier to review?

seladb avatar Jul 24 '25 07:07 seladb

@seladb Sure will work on it

egecetin avatar Jul 24 '25 11:07 egecetin

@seladb This PR is clear now and ready for the review

egecetin avatar Aug 06 '25 09:08 egecetin