seladb
seladb
@raissi-oussema I think this PR is almost ready to merge. Can you address the remaining comments?
@raissi-oussema thank you so much for working on this PR! 🙏 I really appreciate your hard work and dedication, and I'm sorry it took a bit long to get this...
> @seladb Maybe we can merge the PR? Or do you prefer to find some native speakers to take a look? It'd be great if another native speaker could review....
@dromniscience Cisco HDLC is not currently supported, but maybe you can consider adding support for it?
@dromniscience Cisco HDLC was added in this PR: https://github.com/seladb/PcapPlusPlus/pull/1747
@zyl-one did you try building v24.09?
> @zyl-one @seladb GCC 4.9.1 is a bit outdated. Maybe a compiler related error? @zyl-one can you try to build it on a later version of GCC?
Having both `doMtuCheck()` as a public method and `checkMtu()` as a protected method is even more confusing IMO. I'm ok with removing the error log in `doMtuCheck()` if you think...
@Dimi1010 I'm still not convinced this change is needed. We add multiple public methods to `PcapLiveDevice` which makes the API more complex for no apparent reason. Also - the existing...
ok @Dimi1010 let's go with your suggestion. But can we make the new MTU check methods private? We can leave the existing `doMtuCheck()` public even though it's not ideal. Please...