Sam Gleske

Results 397 comments of Sam Gleske

Okay so I see three action items for me: - Update this PR with less hard coding and better options for content creators, respect both turret and gun angles. Support...

I will add that the feature of having installable bays has been pretty enjoyable to play with. I am replaying the the game start to finish with my developed PRs...

> No need to create an RFC for the test-infrastructure. Just following up here since I said so in discord. I will not be writing an RFC (in case someone...

> If it gets decided that this is a mechanic to be supported by the engine, then it better be vanilla-ready. I wouldn't open a PR that I didn't think...

@tehhowch to clarify, could you expand on what you mean by vanilla ready? The change is stable and works. There is some feedback per code review but once implemented it...

@petervdmeer > I'm sorry to disappoint you, but this feature is far from vanilla ready. I listed a number of things https://github.com/endless-sky/endless-sky/pull/6792#issuecomment-1119036605 and that is just a start of what...

Let's set code implementation aside for a second and talk purely data files. Instead of the `Fighter Bay` weapon attribute, I want to implement this in a way that is...

@petervdmeer > if tehhowch expresses doubts about some idea, then consider that to be an early warning that all work on this PR might be in vain in the end....

I put it back into review when I have addressed outstanding feedback

https://discordapp.com/channels/251118043411775489/308902312741568512/980224843859496970 Another idea: bay filter for the kind of ship that is allowed to be stored. Kitteh: > Could be it be feasible to design a heavy warship that during...