Sam Gleske

Posted a video in discord https://discordapp.com/channels/251118043411775489/266345072554016768/979119391532798042

https://discord.com/channels/251118043411775489/266345072554016768/979228330475794462 a review from the original person reporting this which caused me to look into it: matthew.najmon says: > samrocketman btw, got a chance to test out the new fighter...

# Warning After some more extensive play testing I've found this change to be unstable. `government` segfaults (which I removed to see if the issue was fixed). Upon removal then...

Locally, I completely reverted `source/Ship.cpp` and still got a segfault. I think this has to do with how I'm calling CanBeCarried in `source/AI.cpp` and Ship.cpp is just a symptom.

# Fixed segfault The segfault was indeed caused by AI. 90a54bce6d340b8c302250d884b70c096ec383d3 is the fix. # Question I went ahead and reverted CanCarry. Should I use my original CanCarry implementation which...

I am not convinced this is stable, yet so am converting to a draft.

# Ready for review I have resolved all stability issues and outstanding bugs. After play testing this feels good so am comfortable with a general review/merge.

@quyykk > I think the better way to solve this is to look at the code that is responsible for finding a new parent. Probably the reason why fighters don't...

> A couple lines above there's a comment explaining that if there is no suitable parent it assigns the flagship, even if it can't carry. But then later on you...

I started from scratch based on what I've learned about performance tuning in #6726 . @quyykk ready for a fresh review