image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Add clearAllSteps method to sequencer object

Open rishabhshuklax opened this issue 5 years ago • 3 comments

Fixes #1613

clear-steps

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

rishabhshuklax avatar Feb 05 '20 12:02 rishabhshuklax

Codecov Report

Merging #1615 into main will decrease coverage by 1.34%. The diff coverage is 13.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   66.67%   65.33%   -1.35%     
==========================================
  Files         130      132       +2     
  Lines        2686     2746      +60     
  Branches      433      439       +6     
==========================================
+ Hits         1791     1794       +3     
- Misses        895      952      +57     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/ImageSequencer.js 49.40% <20.00%> (-0.91%) :arrow_down:
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) :arrow_down:

codecov[bot] avatar Feb 05 '20 12:02 codecov[bot]

@publiclab/is-reviewers please review this

rishabhshuklax avatar Feb 05 '20 12:02 rishabhshuklax

gitpod-io[bot] avatar Jul 12 '20 14:07 gitpod-io[bot]