Javier Chávarri
Javier Chávarri
Hm. Can't repro with `/* */` comments now. But `//` definitely make merlin unhappy.
> 5. Start bsb watch process; npm start (or ./node_modules/bs-platform/lib/bsb.exe -make-world -w) This is the main DX issue imo: users tend to keep running `bsb` watcher manually after adding `bsb`...
@aloifolia Could you paste the output from the terminal, please?
Thanks! I see the issue now. At the beginning, there's a line where the inlined code is breaking over the next line: ``` 886 │ [@bs.module "react"] external reactIsValidElement :...
Thanks for your help taking this to the finish line. One thing that the branch / PR should fix that is not at the moment is restoring compatibility with ReScript....
the following code: ```reason let t = // a React.null // b // c ; ``` gets refmt'd into: ```reason let t = React.null // b ; // c //...
@anmonteiro Ah yeah, it definitely is, I was also using gen_js_api 😄 Feel free to close it as duplicate 👍
> and the fact that gen_js_api does not support reason natively @Lupus The gen_js_api ppx should work out of the box, no? For the binary applied to interface files, I...
> what issues? mostly problems when installing `styled-ppx` on macos, due to the dependency on `pcre` (which also requires `pkg-config`).
See related https://github.com/reasonml/reason-react/pull/750#discussion_r1264337238.