Javier Chávarri

Results 174 comments of Javier Chávarri

So, from what I understand, this task would require splitting the `| Runtime | Ml` case which is currently handled [similarly](https://github.com/thangngoc89/bucklescript/blob/f7d9dd93ad162dd215776921b7c52021a7820e9c/jscomp/core/js_name_of_module_id.ml#L207-L208), into two different cases, right? If this issue is...

Thanks for the explanation and the example @thangngoc89. I am trying to get the cmj path from a loaded module using `Lam_compile_env.get_package_path_from_cmj`, which is what the native code [is using](https://github.com/bucklescript/bucklescript/blob/f7d9dd93ad162dd215776921b7c52021a7820e9c/jscomp/core/js_name_of_module_id.ml#L115),...

@thangngoc89 I just managed to build sketch locally with reason-react prebuilt, and still get the `BROWSER` string in the returned value from `get_package_path_from_cmj`. I also tried using `Config_util.find_opt js_file` to...

BuckleScript does not exist anymore and I don't think we will have the resources to build a brand new Sketch engine for ReScript anytime soon, so closing related issues.

> I can create a draft of this change if make sense. @maxlibin yes please. As reference, we can also check observable. It has much more functionality than what we...

@hhugo I don't think the current behavior of `[@@jsoo.optdef]` is totally unexpected, but I was hoping to have a way for the property to not be included in the resulting...

In case it helps, [this](https://github.com/BuckleScript/bucklescript/blob/b55e6f24a0f18ce7844d5d4c05cdcf2ca69fccae/jscomp/syntax/ast_external_process.ml#L415-L517) is the part of the BuckleScript codebase where the `external ... = "" [@@bs.obj]` case is handled. [Here's](https://bucklescript.github.io/bucklescript/Manual.html#_create_js_objects_using_external) the documentation for it. As you can...

This is a sample implementation I did using the existing APIs: ```ocaml let optInj prop opt = match opt with | Some (s) -> [|(prop, Js.Unsafe.inject s)|] | None ->...

> What do you expect the generated javascript to be. Creating an empty object and and have a bunch of if-then to set fields if not undefined? @hhugo Yes, in...

ftr I pushed some branch to make bisect runtime build on melange. I left the PR as draft so that others interested can find it, but I don't think it...