Javier Chávarri

Results 174 comments of Javier Chávarri

@davesnx what are your thoughts on this? > I wonder if we should mention this difference between uppercase / lowercase components in our documentation. @anmonteiro We do mention something already:...

We could mention [opam-check-npm-deps](https://ocaml.org/p/opam-check-npm-deps/), see related https://github.com/reasonml/reason-react/pull/760

@davesnx please take a look.

> patch 0.11 in opam with the same upper bound Second item is being added in https://github.com/ocaml/opam-repository/pull/24367.

I started testing the approach in #813 (which is in the end very similar to this 😄 ) and noticed a case in reshowcase that breaks. The code breaks [here](https://github.com/ahrefs/reshowcase/blob/cbd91b32e6ef86b07aef69b25a2da48d7b82d89f/src/ReshowcaseUi.re#L328)...

True. Splitting the processing in 2 steps: - first to remove the null values (can use `Belt.filterMap(id)` to remove `None` values - another to create the elements solves the issue....

Another interesting case I found is `React.Children.mapWithIndex` and similar functions, e.g. ```reason [@react.component] let make = (~children) => {children->React.Children.mapWithIndex((element, index) => element )} ; ``` I fixed it in https://github.com/reasonml/reason-react/commit/29fc9be70078036f476e63b0993a81c12ec923d3....

Ah, another thing I forgot is that `React.Children` is quite problematic. I was reading about it on the React official docs and they suggest again using anything in that module,...

Running watch mode with `--terminal-persistence=preserve` will show the file that triggered a rebuild, regardless if the previous build has finished or not, e.g. ``` $ dune build @foo -w --terminal-persistence=preserve...

That could work. I personally haven't tested promotion mode much (or at all 😅 ) with Melange. But even if I had, it has a couple of downsides: - The...