styled-ppx icon indicating copy to clipboard operation
styled-ppx copied to clipboard

Add `styled-ppx-native` package

Open jchavarri opened this issue 1 year ago • 3 comments

A couple of people in the Melange community have reported some issues while installing styled-ppx after the addition of the OCaml native side for universal components (mostly server-reason-react).

I think it's nice to keep styled-ppx "free" of any native OCaml deps like server-reason-react, pcre etc, for those users that only need to run it with Melange in browser environments.

This PR adds a new package styled-ppx-native that only includes the native parts of it, and removes the server-reason-react dep from styled-ppx package.

jchavarri avatar Jan 23 '24 16:01 jchavarri

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
styled-ppx ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 8:37am

vercel[bot] avatar Jan 23 '24 16:01 vercel[bot]

A couple of people in the Melange community have reported some issues while installing styled-ppx after the addition of the OCaml native side for universal components (mostly server-reason-react).

LGTM, for example, what issues?

lubegasimon avatar Jan 24 '24 10:01 lubegasimon

what issues?

mostly problems when installing styled-ppx on macos, due to the dependency on pcre (which also requires pkg-config).

jchavarri avatar Jan 24 '24 10:01 jchavarri

Closing this, since I want to polish the instalation for Melange and native in one go. If it causes issues after the polishment, I will reborn the idea of separate packages

davesnx avatar Mar 08 '24 13:03 davesnx