Javier Chávarri

Results 174 comments of Javier Chávarri

Hm there seems to be some issue with the recent change to update `Lib.DB.get_compile_info` to take the lib `dir` as input. When we generate the rules for melange emit stanza,...

I have added another test file in https://github.com/ocaml/dune/pull/9839/commits/4f1b4a71e415bad881f251ae0670d12cde5d3cc2 for the "ultimate" use case I had in mind: defining two libraries with the same name in the same `dune` file, and...

Otherwise, I think the PR is just missing the patch from https://github.com/ocaml/dune/pull/10010, once that's merged, all tests should pass fine.

> The triple `Loc.t * Path.Build.t * Lib_name.t` should be enough. I have instead taken a different approach. I started thinking why does `Ml_sources.make` gets called at all for a...

@rgrinberg I added a test for the case you mentioned in #10026. Re: the issues with `get_compile_info` failing, here is what I understand is happening. Let's say there are two...

Thanks for the reviews and guidance. This PR got a bit long and messy, it has served its purpose as many parts of it were extracted into separate PRs. Starting...

For the record, we observed this behavior is quite tricky to work around once one runs into it, because it's not only necessary to run `dune clean`, but also remove...

One thing that comes to mind is that because melange also uses dune, a new `library` should be added, maybe they could be called `promise.native` and `promise.melange` or something like...

Flexer can't be installed just by copying the .coffee file, due to the dependency with css-layout. It requires to be installed through npm. Follow the instructions on the [readme](https://github.com/jchavarri/Flexer/blob/master/README.md) file....

I found the problem cause already, but I need to come up with a solution. Will update soon (hopefully tonight)