Stephen Sherratt

There was a failing test because this removes the dependency cycle reported in https://github.com/ocaml/dune/issues/4345, where copying a file from a parent directory with the `copy_files` stanza in a public library...

> LGTM. Pleasantly surprised on how cleanly you managed to tack this on. > > How about adding this to `(dirs ..)` as well? Should hopefully be nice and simple....

Head up that I also encounter this segfault on an intel mac

I totally agree with your point about inconsistency. I don't think there's a way to treat the entire `(include_dirs ...)` field as an ordered set because it currently allows terms...

Also, my current implementation makes it an error if the file referred to by `(:include ...)` contains an OSL with 0 or >1 elements. It wouldn't be hard to support...

@rgrinberg based on our discussion I've redesigned this change so that the `include_dirs` field can contain an arbitrary ordered set of `Include_dir.t`s. I factored out the common logic in `Ordered_set_lang.Unexpanded`...

I forgot to update a test when I changed an error message. That's fixed now, and I've also split the tests into multiple files with one file per test case.

Also interested in this!

I don't think this is worth doing anymore as one can now compile the assembly files to object files with a custom rule and then include them with `(extra_objects ...)`....

No the related bug I fixed was that running `dune exec proj` created an unintended _build directory in the current directory (https://github.com/ocaml/dune/pull/6707)